Skip to content

Don't attempt to register web component if already created#95

Merged
texodus merged 1 commit intofinos:masterfrom
timkpaine:check_if_registered
Jan 13, 2021
Merged

Don't attempt to register web component if already created#95
texodus merged 1 commit intofinos:masterfrom
timkpaine:check_if_registered

Conversation

@timkpaine
Copy link
Copy Markdown
Member

The browser complains loudly and there may be some other side effects (e.g. in perspective's fat webpack bundle when used with other libraries that leverage regular-table, such as ipyregulartable)

s/name/actual name

reverse logic
@timkpaine timkpaine requested a review from texodus October 21, 2020 00:47
@texodus
Copy link
Copy Markdown
Member

texodus commented Jan 13, 2021

Thanks for the PR! Looks good!

I'm compelled to leave for historical record a reminder, that if you encounter issues with regular-table duplicate registering, you have multiple copies of regular-table.js in your bundle and this is never a good sign.

@texodus texodus merged commit 7ea7a55 into finos:master Jan 13, 2021
@texodus texodus added the bug Concrete, reproducible bugs label Jan 13, 2021
@timkpaine timkpaine deleted the check_if_registered branch November 29, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Concrete, reproducible bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants