Don't attempt to register web component if already created#95
Merged
texodus merged 1 commit intofinos:masterfrom Jan 13, 2021
timkpaine:check_if_registered
Merged
Don't attempt to register web component if already created#95texodus merged 1 commit intofinos:masterfrom timkpaine:check_if_registered
texodus merged 1 commit intofinos:masterfrom
timkpaine:check_if_registered
Conversation
s/name/actual name reverse logic
Member
|
Thanks for the PR! Looks good! I'm compelled to leave for historical record a reminder, that if you encounter issues with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The browser complains loudly and there may be some other side effects (e.g. in
perspective's fat webpack bundle when used with other libraries that leverage regular-table, such asipyregulartable)