Supported a list of files in multipart form data#633
Merged
symphony-elias merged 1 commit intofinos:mainfrom Mar 11, 2022
symphony-elias:PLAT-11827
Merged
Supported a list of files in multipart form data#633symphony-elias merged 1 commit intofinos:mainfrom symphony-elias:PLAT-11827
symphony-elias merged 1 commit intofinos:mainfrom
symphony-elias:PLAT-11827
Conversation
|
|
||
| private void addFileToFormParam(String paramKey, File paramValue, MultiValueMap<String, Object> formValueMap) { | ||
| File file = paramValue; | ||
| formValueMap.add(paramKey, new FileSystemResource(file)); |
There was a problem hiding this comment.
does this file get stored in the machine?
Contributor
Author
There was a problem hiding this comment.
The file has to be stored on the machine and accessible by the Java process running this.
I guess your question is: does the file get closed after HTTP request is made. I have to check that.
Contributor
symphony-youri
left a comment
symphony-youri
left a comment
There was a problem hiding this comment.
🙏 put a description in the commit message to give a bit of context
The HttpClient provided by the BDK was not supporting File objects as a form param value whether it was one single File object or several File objects for a given form param key
symphony-youri
approved these changes
Mar 11, 2022
symphony-mariacristina
approved these changes
Mar 11, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #631
Checklist