Skip to content

Upgrade Symphony API specifications for parent message id / Upgrade Spring Boot to 2.6.7#654

Merged
symphony-youri merged 2 commits intofinos:mainfrom
symphony-youri:upgrade-spec-parent-message-id
Apr 28, 2022
Merged

Upgrade Symphony API specifications for parent message id / Upgrade Spring Boot to 2.6.7#654
symphony-youri merged 2 commits intofinos:mainfrom
symphony-youri:upgrade-spec-parent-message-id

Conversation

@symphony-youri
Copy link
Copy Markdown
Contributor

Description

Agent API is now returning the parentMessageId as part of V4Message
payloads to retrieve the original message in case of a forward or a
reply.

Dependencies

finos/symphony-api-spec#150

Checklist

  • Referenced an issue in the PR title or description
  • Filled properly the description and dependencies, if any
  • Unit/Integration tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

Agent API is now returning the parentMessageId as part of V4Message
payloads to retrieve the original message in case of a forward or a
reply.
@symphony-youri symphony-youri requested a review from a team as a code owner April 26, 2022 12:25
@symphony-youri symphony-youri changed the title Upgrade Symphony API specifications for parent message id Upgrade Symphony API specifications for parent message id / Upgrade Spring Boot to 2.6.7 Apr 27, 2022
@symphony-youri
Copy link
Copy Markdown
Contributor Author

@symphony-elias Ok for you?

@zawiszap
Copy link
Copy Markdown

I'm sorry for commenting in original review. Will this change allow to retrieve original messageId of V4Event in RealTimeEventListener? Currently only the event.payload is being passed in RealTimeEventType handler functions, therefore V4Event messageId cannot be accessed by BDK user.

@symphony-youri
Copy link
Copy Markdown
Contributor Author

Hi @zawiszap,
You are welcome to comment here, happy to see external contributors to the BDKs :).

This information (parentMessageId) along with the messageId should be accessible via V4MessageSent.message field that is used in the listener.

@symphony-youri symphony-youri merged commit 51a26ca into finos:main Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants