Skip to content

Upgrade github workflow action versions and dependencies version #688

Merged
yinan-symphony merged 1 commit intofinos:mainfrom
yinan-symphony:feature/inline-template
Nov 16, 2022
Merged

Upgrade github workflow action versions and dependencies version #688
yinan-symphony merged 1 commit intofinos:mainfrom
yinan-symphony:feature/inline-template

Conversation

@yinan-symphony
Copy link
Copy Markdown
Contributor

@yinan-symphony yinan-symphony commented Nov 15, 2022

  • Upgrade github checkout action version.
  • Upgrade spring boot version
  • Add inline template doc and sample code

Description

Closes #[ISSUE NUMBER]

Please put here the intent of your pull request.

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced an issue in the PR title or description
  • Filled properly the description and dependencies, if any
  • Unit/Integration tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

@yinan-symphony yinan-symphony force-pushed the feature/inline-template branch 2 times, most recently from 3639584 to d60b20a Compare November 15, 2022 13:26
Copy link
Copy Markdown
Contributor

@symphony-soufiane symphony-soufiane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, maybe just change the PR title or the commit message as the main change is fixiing the workflows and the dependeencies update

 - Upgrade github checkout action version.
 - Upgrade spring boot version
 - Add inline template doc and sample code
@yinan-symphony yinan-symphony force-pushed the feature/inline-template branch from d60b20a to 70456e0 Compare November 16, 2022 08:45
@yinan-symphony yinan-symphony changed the title Add inline template to TemplateEngine Upgrade github workflow action versions and dependencies version Nov 16, 2022
@yinan-symphony yinan-symphony merged commit 0c8fd1d into finos:main Nov 16, 2022
@yinan-symphony yinan-symphony deleted the feature/inline-template branch November 16, 2022 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants