Add actuator health endpoint to app starter#737
Conversation
yinan-symphony
force-pushed
the
feature/health-check
branch
7 times, most recently
from
371b8f6 to
ca50ad9
Compare
The health endpoint uses the HealthService to provide the core components health status, as well as the DatafeedLoop running process status, if the running process counter is not updated in a fixed time range, the process is considered as 'DOWN'.
yinan-symphony
force-pushed
the
feature/health-check
branch
from
ca50ad9 to
250a923
Compare
| management: | ||
| endpoint: | ||
| web: | ||
| exposure: | ||
| include: 'symphonyBdk' | ||
| health: | ||
| show-details: "ALWAYS" | ||
| ``` |
There was a problem hiding this comment.
we need maybe to update configuration.md too with this new added config: https://github.com/finos/symphony-bdk-java/blob/main/docs/configuration.md
There was a problem hiding this comment.
Just check this configuration.md content, il looks like it s more like BDK configuration only, if we put this into configuration.md, i feel that it s kinda mix between BDK and spring boot config, especially considering that this config is in app-starter only.
| * | ||
| * @return timestamp value in long | ||
| */ | ||
| long lastPullTimestamp(); |
There was a problem hiding this comment.
I don't think we want to expose this method in DF loop api to users.
There was a problem hiding this comment.
then how to get this timestamp in a generic way ? another way is to move the health check method inside the DatafeedLoop, but i would say expose a last pull timestamp method in this interface is more relevant than exposing a health check method.
2 participants
The health endpoint uses the HealthService to provide the core components health status, as well as the DatafeedLoop running process status, if the running process counter is not updated in a fixed time range, the process is considered as 'DOWN'.
Description
Closes #[ISSUE NUMBER]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist