#680: not set bot username as Datafeed tag#738
Merged
symphony-soufiane merged 3 commits intofinos:mainfrom Dec 9, 2022
Merged
Conversation
The datafeed tag is an internal feature and the tag property is optional in the configuration. So far, when no tag is configured, the bot username was used as a tag. This leads to production issues when the tag is an old hanging one. In this PR, we only set the tag in datafeed calls when it is provided in configuration, otherwise a null value is put. For the same occasion, I corrected the datafeed documentation with some links returning a 404 page error. The tag property is not documented as it is only internal feature.
yinan-symphony
approved these changes
Dec 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The Datafeed tag is an internal feature and the tag property is optional in the configuration. So far, when no tag is configured, the bot username was used as a tag. This leads to production issues when the tag is an old hanging one. In this PR, we only set the tag in Datafeed calls when it is provided in configuration, otherwise a null value is put. For the same occasion, I corrected the Datafeed documentation with some links returning a 404 page error. The tag property is not documented as it is only internal feature.