Remove CE health check from the indicator#745
Merged
yinan-symphony merged 1 commit intofinos:mainfrom Feb 23, 2023
Merged
Conversation
| healthIndicator.doHealthCheck(builder); | ||
| Health build = builder.build(); | ||
| assertThat(build.getStatus().getCode()).isEqualTo("WARNING"); | ||
| assertThat(build.getStatus().getCode()).isEqualTo("UP"); |
Contributor
There was a problem hiding this comment.
let's rename this test then
| .withDetail(DF, services.get(DF)) | ||
| .withDetail(KM, services.get(KM)) | ||
| .withDetail(AGT, users.get(AGT)) | ||
| .withDetail(CE, users.get(CE)) |
Contributor
There was a problem hiding this comment.
do we hide details about CE too? Maybe we can keep details and only ignore CE in the global status
symphony-soufiane
approved these changes
Feb 23, 2023
yinan-symphony
force-pushed
the
task/health-ce
branch
from
6cc59f0 to
ed75c62
Compare
CE health status is optional, should not impact the BDK bot global health status, remove it from the check list.
yinan-symphony
force-pushed
the
task/health-ce
branch
from
ed75c62 to
54b4fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CE health status is optional, should not impact the BDK bot global health status, remove it from the check list.
Description
Closes #[742]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist