Skip to content

Make DF recreation retry when client error#746

Merged
yinan-symphony merged 1 commit intofinos:mainfrom
yinan-symphony:bugfix/retry-df
Mar 1, 2023
Merged

Make DF recreation retry when client error#746
yinan-symphony merged 1 commit intofinos:mainfrom
yinan-symphony:bugfix/retry-df

Conversation

@yinan-symphony
Copy link
Copy Markdown
Contributor

When reading DF events fails with client error 400, the API call is doing a retry by recreating the DF, the DF recreation API call unfortunately does not have a retry on client error.

This commit fixed this bug.

Description

Closes #[ISSUE NUMBER]

Please put here the intent of your pull request.

Dependencies

List the other pull requests that should be merged before/along this one.

Checklist

  • Referenced an issue in the PR title or description
  • Filled properly the description and dependencies, if any
  • Unit/Integration tests updated or added
  • Javadoc added or updated
  • Updated the documentation in docs folder

When reading DF events fails with client error 400, the API call
is doing a retry by recreating the DF, the DF recreation API call
unfortunately does not have a retry on client error.

This commit fixed this bug.
@symphony-soufiane
Copy link
Copy Markdown
Contributor

LGTM, we need to support the same in Python BDK.

@yinan-symphony yinan-symphony merged commit 279fe30 into finos:main Mar 1, 2023
@yinan-symphony yinan-symphony deleted the bugfix/retry-df branch May 23, 2023 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants