Fix byte-buddy class loading failure#780
Merged
yinan-symphony merged 2 commits intofinos:mainfrom Sep 12, 2023
Merged
Conversation
The byte-buddy default classloading strategy requires the access to Java internal methods, which are sealed by JPMS since Jdk11. The fix is to change the strategy from default one to UsingLookup, according to the recommendation of byte-buddy doc. Add "Automatic-Module-Name" attribute in main MANIFEST.MF entry.
ystxn
approved these changes
Sep 12, 2023
yinan-symphony
force-pushed
the
bugfix/byte-buddy
branch
from
8c06555 to
f71effa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The byte-buddy default classloading strategy requires the access to Java internal methods, which are sealed by JPMS since Jdk11. The fix is to change the strategy from default one to UsingLookup, according to the recommendation of byte-buddy doc.
Add "Automatic-Module-Name" attribute in main MANIFEST.MF entry.
Description
Closes #[ISSUE NUMBER]
Please put here the intent of your pull request.
Dependencies
List the other pull requests that should be merged before/along this one.
Checklist