adding copy url functionality to socialshare by ayezinzu · Pull Request #417 · finsweet/attributes

ayezinzu · 2023-07-09T18:44:46Z

No description provided.

packages/socialshare/src/actions/trigger.ts

alexiglesias93

Please add tests!

alexiglesias93 · 2023-07-13T13:04:34Z

packages/socialshare/src/actions/trigger.ts

+      // if platform is copy button
+      if (platform === 'copy') {


If there was an award for the most redundant comments, this one would definitely be a candidate to win 😆

Yeah, thanks for pointing this out, I figured what I was doing something wrong here 😅

Is it because other devs have done the same thing in the past?

alexiglesias93 · 2023-07-13T13:06:01Z

packages/socialshare/src/actions/trigger.ts


+      // if platform is copy button
+      if (platform === 'copy') {
+        await triggerCopyShare();


Jokes aside, this should not be placed here.
You're triggering the copy before even checking if the trigger that was clicked was the copy.
Also, that await here is not needed. Although copying is async, you are not performing any other actions afterwards to it's unnecessary to await for it.

Updating in next commit!

alexiglesias93 · 2023-07-13T13:07:01Z

packages/socialshare/src/actions/trigger.ts

+  try {
+    await navigator.clipboard.writeText(windowUrl);
+  } catch (err) {
+    Debug.alert('MESSAGE_TO_SHOW', 'error');


We're deprecating the Debug component in v2.
You can just use console.error.
Also, MESSAGE_TO_SHOW?

Updating in next commit!

alexiglesias93 · 2023-07-13T13:08:23Z

packages/socialshare/src/factory.ts

+  copy() {
+    // doesn't need to store any data and instances are irrelevant
+    return;


Perhaps it would make sense to create the specific callback for each platform inside the creators.
This way you will be able to treat the copy as any other platform.

I have updated the logic a bit to address this thing. Might be a different approach from what you proposed as I thought it adapted more to how this is built. Let me know your thoughts!

alexiglesias93 · 2023-07-13T13:10:00Z

packages/socialshare/src/utils/constants.ts

+      /**
+       * Defines a copy social button
+       */
+      copy: generateDynamicAttibuteValue(COPY_ELEMENT_KEY),


copy doesn't require interacting with other elements so it's not necessary to be a dynamic attribute.

How would we get the selectors for the copy button then? @alexiglesias93

robertkibet · 2023-07-17T11:17:55Z

@ayezinzu @alexiglesias93 this PR is supposed to use v1 or v2? 🤔

ayezinzu · 2023-07-17T13:32:56Z

@ayezinzu @alexiglesias93 this PR is supposed to use v1 or v2? 🤔

I believe v1
@alexiglesias93 can confirm.

ayezinzu · 2023-07-17T13:33:35Z

Hey team, I will come back with the updates for the feedback provided early this week!

vercel · 2023-07-20T02:57:14Z

@IftodiRadu is attempting to deploy a commit to the Finsweet Team on Vercel.

To accomplish this, @IftodiRadu needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

vercel · 2023-07-20T15:31:50Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
attributes	❌ Failed (Inspect)			Jul 20, 2023 3:36pm

vercel · 2023-08-08T09:26:09Z

@ayezinzu is attempting to deploy a commit to the Finsweet Team on Vercel.

To accomplish this, @ayezinzu needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

alexiglesias93

@ayezinzu CI is failing

ayezinzu · 2023-08-08T12:31:31Z

@ayezinzu CI is failing

@alexiglesias93 should be fixed now

alexiglesias93

Also, please add a changeset

alexiglesias93 · 2023-08-10T09:25:14Z

packages/socialshare/tests/socialshare.spec.ts

+      const dataUrlAttribute = await copyLocator.getAttribute('data-url');
+
+      await expect(dataUrlAttribute).toEqual(currentUrl);


this is quite redundant, you should be checking if the clipboard contains the correct text:

const clipboardText = await page.evaluate("navigator.clipboard.readText()"); expect(clipboardText).toEqual(currentUrl);

@alexiglesias93 Firefox only supports reading the clipboard in browser extensions, using the "clipboardRead" extension permission. Thus, we can't access that property on Firefox. That is why we use clipboard.js which seems to be working fine.

Then you could test by using execCommand to trigger a Paste action into a textarea, and check the contents that were pasted

Okay, will update to that.

alexiglesias93 · 2023-08-10T09:25:49Z

packages/socialshare/src/utils/configureCopyButton.ts

+  });
+
+  // setting data-url attribute for testing purposes
+  copyButton.setAttribute('data-url', copyUrl);


this is not necessary, check my other comment for reference

Referenced in the comment here #417 (comment)

ayezinzu · 2023-08-16T14:57:45Z

Also, please add a changeset

Hi @alexiglesias93
Have we not initiated any changesets on the master branch? I am unable to add a changeset

vercel · 2024-08-15T07:29:45Z

An owner of the Finsweet Team on Vercel declined @ayezinzu's request to join.

In order for their commit to be deployed, @ayezinzu must push and request access again.

ayezinzu added 2 commits July 9, 2023 20:42

adding copy url functionality to socialshare

8d0759c

updating package

d25d175

robertkibet reviewed Jul 11, 2023

View reviewed changes

packages/socialshare/src/actions/trigger.ts Outdated Show resolved Hide resolved

adding Debug statement

3396bc3

robertkibet reviewed Jul 12, 2023

View reviewed changes

packages/socialshare/src/actions/trigger.ts Outdated Show resolved Hide resolved

alexiglesias93 requested changes Jul 13, 2023

View reviewed changes

addressing reviews and updating logic

8f01409

refactor socialshare factory

fe654e2

vercel bot temporarily deployed to Preview July 20, 2023 15:32 Inactive

fix: window not accessible during build

f8f7b59

vercel bot temporarily deployed to Preview July 20, 2023 15:36 Inactive

updating copy url functionality and adding tests

22a0efb

alexiglesias93 requested changes Aug 8, 2023

View reviewed changes

updating lock file

727bbe7

alexiglesias93 requested changes Aug 10, 2023

View reviewed changes

update tests to simulate paste event

ecf6ac7

alexiglesias93 mentioned this pull request Sep 19, 2023

Reflect all open v1 PR updates in v2 #471

Open

robertkibet mentioned this pull request Sep 29, 2023

Mixed v1 updates: Resolve already fixed v1 issues list #480

Open

6 tasks

robertkibet assigned ayezinzu Sep 29, 2023

robertkibet added the attribute-socialshare label Sep 29, 2023

alexiglesias93 unassigned ayezinzu Feb 5, 2025

alexiglesias93 closed this May 6, 2025

alexiglesias93 deleted the copyurl-socialshare branch May 6, 2025 13:20

		const dataUrlAttribute = await copyLocator.getAttribute('data-url');

		await expect(dataUrlAttribute).toEqual(currentUrl);

Conversation

ayezinzu commented Jul 9, 2023

Uh oh!

Uh oh!

Uh oh!

alexiglesias93 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ayezinzu Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

robertkibet commented Jul 17, 2023

Uh oh!

ayezinzu commented Jul 17, 2023

Uh oh!

ayezinzu commented Jul 17, 2023

Uh oh!

vercel bot commented Jul 20, 2023

Uh oh!

vercel bot commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Aug 8, 2023

Uh oh!

alexiglesias93 left a comment

Choose a reason for hiding this comment

Uh oh!

ayezinzu commented Aug 8, 2023

Uh oh!

alexiglesias93 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexiglesias93 Aug 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ayezinzu commented Aug 16, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Aug 15, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

ayezinzu Jul 20, 2023 •

edited

Loading

vercel bot commented Jul 20, 2023 •

edited

Loading

alexiglesias93 Aug 10, 2023 •

edited

Loading

ayezinzu commented Aug 16, 2023 •

edited

Loading