refactor(cli): split install selection and manifest resolution helpers#52
Merged
refactor(cli): split install selection and manifest resolution helpers#52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
surge installcommand implementation from a singleinstall.rsfile into aninstall/module treecrates/surge-cli/src/commands/install/selection.rscrates/surge-cli/src/commands/install/resolution.rsexecuteand the local/remote install execution flow ininstall/mod.rsso this phase only extracts early-resolution logicinstall.rstoinstall/mod.rswith the reduced production-line countWhy
crates/surge-cli/src/commands/install.rshad become the largest file in the workspace and mixed interactive selection, manifest/storage resolution, and install execution in one module. This phase peels off the low-risk helper surfaces first so later install refactors can work against a smaller orchestration root.Impact
install/mod.rspath instead of the removed flat fileValidation
git submodule update --init --recursive./scripts/sync-surge-core-vendor.sh --check./scripts/check-version-sync.shcargo fmt --all -- --check./scripts/check-maintainability.shcargo test -p surge-cli commands::install::tests::cargo check -p surge-cliRUSTFLAGS="-D warnings" cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedanticdotnet format dotnet/Surge.slnx --verify-no-changesdotnet test dotnet/Surge.slnx --configuration Release