Change unit type to notify with startup timeout and exit status config#19
Merged
fiorix merged 3 commits intofiorix:mainfrom Mar 3, 2026
Merged
Change unit type to notify with startup timeout and exit status config#19fiorix merged 3 commits intofiorix:mainfrom
fiorix merged 3 commits intofiorix:mainfrom
Conversation
Owner
|
Update the docs with the defaults too? |
fiorix
approved these changes
Mar 2, 2026
Owner
fiorix
left a comment
fiorix
left a comment
There was a problem hiding this comment.
LGTM except for missing docs update
hodgesds
force-pushed
the
unit-type-notify
branch
from
1c8ba65 to
a470a9a
Compare
Owner
|
Hm. Needs moar rebase. |
Switch the sdme@.service template from Type=simple to Type=notify so systemd waits for the container's readiness notification before considering the unit started. Add TimeoutStartSec=2min to allow sufficient boot time, and RestartForceExitStatus=133 / SuccessExitStatus=133 so exit code 133 triggers a clean restart cycle. Update test_unit_template assertions accordingly.
Document the notify service type, startup timeout, and exit status handling in the Systemd integration and Key Modules sections.
Document the notify service type, startup timeout, and exit code 133 handling in the DESCRIPTION and FILES sections of sdme(1).
hodgesds
force-pushed
the
unit-type-notify
branch
from
a470a9a to
dc4793a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch the sdme@.service template from Type=simple to Type=notify so systemd waits for the container's readiness notification before considering the unit started. Add TimeoutStartSec=2min to allow sufficient boot time, and RestartForceExitStatus=133 / SuccessExitStatus=133 so exit code 133 triggers a clean restart cycle. Update test_unit_template assertions accordingly.