feat(auth): surface GIdP password policy violations with actionable error messages#2333
Merged
Merged
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for Google Identity Platform password policy requirements. It adds a new PasswordPolicyViolationException class, updates exception mapping in AuthException.from to parse password policy requirements from FirebaseAuthWeakPasswordException, handles exceptions in EmailAuthScreen, and adds comprehensive unit tests. The review feedback suggests making the bracket parsing in parsePasswordPolicyRequirements more robust by searching relative to the policy substring, and specifying a locale (such as Locale.US) when calling uppercase() to avoid locale-specific string transformation issues.
just1and0
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2128.
When Google Identity Platform password policy enforcement is enabled, the Firebase Auth SDK returns a
PASSWORD_DOES_NOT_MEET_REQUIREMENTSerror with the specific failing constraints.Previously FirebaseUI silently swallowed these errors — users saw nothing or a generic "unknown error" dialog.
Changes
AuthException.PasswordPolicyViolationExceptionwith a human-readable message and the list of failing requirementsPASSWORD_DOES_NOT_MEET_REQUIREMENTSin bothFirebaseAuthWeakPasswordException.reasonand the rawFirebaseExceptionmessage (actual type from SDK 24.0.1+)AuthException.from()soFirebaseAuthWeakPasswordExceptionis no longer matched asInvalidCredentialsExceptionErrorRecoveryDialogwith a "Try again" actioncatch {}inEmailAuthScreen.onSignUpClickthat was discarding all sign-up errorsExpected Behavior