Skip to content

Conversation

@kylebshr
Copy link
Contributor

@kylebshr kylebshr commented Aug 19, 2016

Dynamic frameworks were introduced with iOS 8, and I believe cocoapods use_frameworks! will also only work on iOS 8 or greater.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@kylebshr
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@morganchen12
Copy link
Contributor

FirebaseUI does support iOS 7 iirc, but that's because there are some giant hacks in place (if you look into the repo, there's no framework targets even though use_frameworks! works). This minimum version bump and abandoning the giant hacks is something I'd like to do in the very near future.

@kylebshr
Copy link
Contributor Author

@morganchen12 that's very interesting. I also wasn't trying to say the project isn't compatible with iOS 7, just that you normally can't install with use_frameworks! on iOS 7. But you're saying the project actually will work on iOS 7 with use_frameworks!? If so, I'll close the PR :)

@morganchen12
Copy link
Contributor

Ah, I see what you mean. use_frameworks! should fail on iOS 7 regardless of our hacks if we're dynamically linking, since iOS 7 just doesn't support dylibs. I'd have to take a closer look and see what's going on, but I'm hoping to override all this stuff and just bump our minimum version to iOS 8 anyway.

@morganchen12
Copy link
Contributor

Yeah I lied, FirebaseUI doesn't support iOS 7 (nor should it). I'll merge this ahead of time to not mislead people.

Thanks @kylebshr!

@morganchen12 morganchen12 merged commit 6ef7be1 into firebase:master Aug 30, 2016
@yorgosg
Copy link

yorgosg commented Aug 31, 2016

So, FirebaseUI no longer supports iOS 7? Is this only for Swift?

This was referenced Oct 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants