feat: Optional logo, languageCode params in AuthConfiguration, added language translations. #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
changed the title
russellwheatley
requested changes
Nov 5, 2025
| // Present modally | ||
| topViewController.present(hostingController, animated: true) | ||
| } | ||
| fatalError("Not implemented") |
Member
There was a problem hiding this comment.
I've made a note to follow up with this after this PR is in so it's a separate issue. Ultimately, we should change from:
public protocol AuthProviderSwift {
@MainActor func createAuthCredential() async throws -> AuthCredential
}
to
public protocol AuthProviderSwift {}
Then we can have a generic protocol for google, twitter, apple, etc like this:
public protocol GenericAuthProviderSwift: AuthProviderSwift {
@MainActor func createAuthCredential() async throws -> AuthCredential
}
and phone can have:
public protocol GenericAuthProviderSwift: AuthProviderSwift {
@MainActor public func verifyPhoneNumber(phoneNumber: String) async throws -> VerificationID {
@MainActor func createAuthCredential(verificationId: String, verificationCode: String) async throws -> AuthCredential
}
Then we can handle each different provider appropriately and not have methods that throw errors. what do you think?
Author
There was a problem hiding this comment.
yeah this works tbh so based on the provider we can have implementations for each.
samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExample.xcodeproj/project.pbxproj
Outdated
Show resolved
Hide resolved
samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExample/App/ContentView.swift
Outdated
Show resolved
Hide resolved
samples/swiftui/FirebaseSwiftUIExample/FirebaseSwiftUIExample/App/ContentView.swift
Outdated
Show resolved
Hide resolved
…xcodeproj/project.pbxproj Co-authored-by: Russell Wheatley <russellwheatley85@gmail.com>
russellwheatley
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added optional logo parameter to AuthConfiguration which overrides firebase auth logo in AuthPickerView.
Added languageCode parameter to AuthConfiguration which allows the developer force a locale (overrides device locale if set).
Added Spanish, German and French language translations.
Language translations