refactor: moved account conflict logic into View layer #1299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demolaf
reviewed
Nov 7, 2025
| // Sign in with the new credential | ||
| _ = try await authService.signIn(credentials: conflict.credential) | ||
|
|
||
| // Successfully handled - conflict is cleared automatically by reset() |
There was a problem hiding this comment.
this is stale since reset() has been removed right?
demolaf
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currentAccountConflictand puts it into the View layer. It is opinionated on how it handles conflict so it is in default ViewsaccountConflictHandler()optional so that if it isn't present, it just throws errors normally. This is in the event users wish to use the default buttons but have other custom Views.reset()from AuthService as it isn't used.