Skip to content

fix: allow user to set their own callback for phone auth #1302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 7, 2025
Merged

fix: allow user to set their own callback for phone auth #1302

merged 3 commits into from
Nov 7, 2025

Conversation

@russellwheatley
Copy link
Member

@russellwheatley russellwheatley commented Nov 7, 2025 •
edited
Loading

  • Allow callback to withPhoneSignIn() so consumer can push to whatever Phone Auth View they wish.
  • Allow callback to withEmailSignIn() so consumer can push to whatever Email Auth View (and/or link) they wish.
  • Remove navigator.push(.mfaResolution) from AuthService and move to View layer.

demolaf
demolaf approved these changes Nov 7, 2025
View reviewed changes
Copy link

@demolaf demolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@russellwheatley russellwheatley merged commit 0a8514e into development Nov 7, 2025
3 of 4 checks passed
@russellwheatley russellwheatley deleted the phone-custom-tap branch November 7, 2025 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@demolaf demolaf demolaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@russellwheatley @demolaf