-
Notifications
You must be signed in to change notification settings - Fork 487
Google provider unittests #160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
yramanchuk
commented
Oct 5, 2016
- update pod file structure
- remove not used framework imports (fixes duplicate loads)
- remove build-2.2.swift
- update google provider unit tests
…rovider-unittests * commit 'c9ed7efac89b51a0c88a28947288eb01f5691687': remove code sign identity from travis script
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending some cleanup
|
|
||
|
|
||
| // OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]); | ||
| // OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these comments
| NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeUnknown userInfo:@{}]; | ||
|
|
||
| // OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]); | ||
| // OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these too
| NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeCanceled userInfo:@{}]; | ||
|
|
||
| // OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]); | ||
| // OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
delete these too