Skip to content

Conversation

@yramanchuk
Copy link
Contributor

  • update pod file structure
  • remove not used framework imports (fixes duplicate loads)
  • remove build-2.2.swift
  • update google provider unit tests

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending some cleanup



// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these comments

NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeUnknown userInfo:@{}];

// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these too

NSError *signInError = [NSError errorWithDomain:@"sign in domain" code:kGIDSignInErrorCodeCanceled userInfo:@{}];

// OCMExpect([mockSignInDelegate signIn:mockSignIn didSignInForUser:mockGoogleUser withError:nil]);
// OCMExpect([mockSignIn signIn]).andCall(mockSignInDelegate, @selector(signIn:didSignInForUser:withError:));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete these too

@yramanchuk yramanchuk merged commit 657f995 into v0.5.6 Oct 5, 2016
@yramanchuk yramanchuk deleted the google-provider-unittests branch October 5, 2016 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants