implement swift auth customization controllers #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Oct 20, 2016
Contributor
morganchen12
left a comment
morganchen12
left a comment
There was a problem hiding this comment.
Had one small comment, otherwise LGTM
| self.auth?.removeStateDidChangeListener(handle) | ||
| } | ||
|
|
||
| self.navigationController?.isToolbarHidden = true; |
Contributor
There was a problem hiding this comment.
May want to move this to viewDidDisappear(_:) so that the toolbar doesn't vanish while the view is animating away, but it's a small detail
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIRCustomAuthUIDelegateauthUI(_ authUI: FIRAuthUI, didSignInWith user: FIRUser?, error: Error?))