Implement additional FUIAuth sign-in call bac #375
Conversation
FirebaseAuthUI/FUIAuth.h
Outdated
| error:(nullable NSError *)error; | ||
| error:(nullable NSError *)error | ||
| __attribute__((deprecated("This is deprecated API and will be removed in a future release." | ||
| "Use authUI:didSignInWithAuthDataResult:error:"))); |
FirebaseAuthUI/FUIAuth.m
Outdated
|
|
||
| if (error) { | ||
| [self invokeResultCallbackWithUser:user error:error]; | ||
| [self invokeResultCallbackWithAuthDataResult:authResult error:error]; |
There was a problem hiding this comment.
If an error exist we shouldn't pass authResult here which should ideally be nil, but at this level we do not know.
| [self showAlertWithMessage:message]; | ||
| }); | ||
| }]; | ||
| // The dispatch is a workaround for a bug in FirebaseAuth 3.0.2, which doesn't call the |
There was a problem hiding this comment.
This bug has been fixed, there is no need to dispatch async to the main queue here again anymore.
| } | ||
|
|
||
| NSString *message = | ||
| [NSString stringWithFormat:FUILocalizedString(kStr_PasswordRecoveryEmailSentMessage), email]; |
There was a problem hiding this comment.
please fix indentation.
morganchen12
left a comment
morganchen12
left a comment
There was a problem hiding this comment.
Please bump the FirebaseAuth dependency in the podfile, otherwise LGTM.
| // The dispatch is a workaround for a bug in FirebaseAuth 3.0.2, which doesn't call the | ||
| // completion block on the main queue. | ||
| dispatch_async(dispatch_get_main_queue(), ^{ | ||
| [self.delegate decrementActivity]; |
There was a problem hiding this comment.
If we're removing this, we should bump the Podfile dependency to 3.1 or higher so this bug doesn't regress for users who haven't updated their pods.
There was a problem hiding this comment.
we already have 4.2 as minimum requirement https://github.com/firebase/FirebaseUI-iOS/blob/master/FirebaseUI.podspec#L50
FirebaseAuthUI/FUIAuth.h
Outdated
| didSignInWithUser:(nullable FIRUser *)user | ||
| error:(nullable NSError *)error; | ||
| error:(nullable NSError *)error | ||
| __attribute__((deprecated("This is deprecated API and will be removed in a future release." |
There was a problem hiding this comment.
You can remove the first line of the deprecation message, since Xcode already adds a "deprecated" label to the warning that's generated.
3 participants
New FUIAuth sign in callback returns FIRAuthDataResult