Skip to content

Conversation

@SirArkimedes
Copy link
Contributor

@SirArkimedes SirArkimedes commented Dec 22, 2017

Fixes issue #380. If FirebaseUI is included in a project that runs pod update, an error no longer occurs from FirebaseUI with this change.

TwitterCore is necessary to be imported on FUITwitterAuth.m because TWTRLogInErrorCodeCancelled is in TwitterCore.

TwitterCore is necessary to be imported on FUITwitterAuth.m since TWTRLogInErrorCodeCancelled is in TwitterCore.
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@morganchen12 morganchen12 merged commit 5e6607e into firebase:master Jan 4, 2018
@morganchen12
Copy link
Contributor

I'm not sure this fixes the pod update issue though, since all we did was change header imports in implementation files and FirebaseUI is distributed as a binary.

@SirArkimedes
Copy link
Contributor Author

@morganchen12 Hmm. I pulled from my fork with Cocoapods and it was fine from my change. Are you seeing it still being an issue when it is in binary form? I'm not sure how to include a binary version with Cocoapods.

@morganchen12
Copy link
Contributor

I'll take a closer look then, don't worry about it. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants