anonymous upgrade for email password accounts #405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
approved these changes
Feb 8, 2018
Contributor
morganchen12
left a comment
morganchen12
left a comment
There was a problem hiding this comment.
LGTM with a few nits.
| return; | ||
| case FIRAuthErrorCodeTooManyRequests: | ||
| [self showAlertWithMessage:FUILocalizedString(kStr_SignInTooManyTimesError)]; | ||
| [FIREmailAuthProvider credentialWithEmail:email password:password]; |
| NSDictionary *userInfo = @{ FUIAuthCredentialKey : credential }; | ||
| NSError *mergeError = [NSError errorWithDomain:FUIAuthErrorDomain | ||
| code:FUIAuthErrorCodeMergeConflict | ||
| userInfo:userInfo]; |
Contributor
There was a problem hiding this comment.
nit: this could maybe be moved into FUIAuthErrors.m.
Contributor
Author
There was a problem hiding this comment.
Moved to FUIAuthErrorUntils.
| completion:^(FIRAuthDataResult *_Nullable authResult, | ||
| NSError *_Nullable error) { | ||
| completeSignInBlock(authResult, error); | ||
| }]; |
Contributor
There was a problem hiding this comment.
nit: You can just pass the block directly to the method here.
[self.auth signInAndRetrieveDataWithCredential:credential completion:completeSignInBlock];
morganchen12
approved these changes
Feb 9, 2018
protocol86
added a commit
that referenced
this pull request
Jul 17, 2018
* anonymous upgrade for email password accounts * addresses comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds anonymous upgrade support for email/password credentials.