Facebook support for email_in_user_when_upgrading #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds support for Facebook when autolinking an exisiting user to a new federated user (Google).
morganchen12
approved these changes
Feb 16, 2018
FirebaseAuthUI/FUIAuth.m
Outdated
| NSString *existingFederatedProviderID = [self federatedAuthProviderFromProviders:providers]; | ||
| // Set of providers which can be auto-linked | ||
| NSSet *supportedProviders = | ||
| [NSSet setWithObjects:FIRGoogleAuthProviderID,FIRFacebookAuthProviderID, nil]; |
Contributor
There was a problem hiding this comment.
nit: space after first comma
FirebaseAuthUI/FUIAuth.m
Outdated
| [googleProviderUI signInWithDefaultValue:emailHint | ||
| [authProviderUI signOut]; | ||
| [authProviderUI signInWithDefaultValue:emailHint | ||
| presentingViewController:presentingViewController |
protocol86
added a commit
that referenced
this pull request
Jul 17, 2018
* Facebook support for email_in_user_when_upgrading Adds support for Facebook when autolinking an exisiting user to a new federated user (Google). * Addresses comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Facebook when autolinking an existing user to a new federated user. Tested with Google and Facebook auth credentials for now.