-
Notifications
You must be signed in to change notification settings - Fork 487
Making some methods of FUIAuthBaseViewController public to make subclassing easier #437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
1 similar comment
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
CLAs look good, thanks! |
1 similar comment
|
CLAs look good, thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but had some doc comment changes (though it looks like these were existing docs bugs)
| - (void)cancelAuthorization; | ||
|
|
||
| /** @fn showSignInAlertWithEmail:provider:handler: | ||
| @brief Displays an alert to conform with user whether she wants to proceed with the provider. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Displays an alert asking the user to confirm whether or not they want to proceed with the selected provider.
|
|
||
| /** @fn incrementActivity | ||
| @brief Increment the current activity count. If there's positive number of activities, display | ||
| and animate the activity indicator with a short period of delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: with a short delay instead of with a short period of delay.
| - (void)decrementActivity; | ||
|
|
||
| /** @fn addActivityIndicator: | ||
| @brief Creates and add activity indicator to the center of the specified view. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creates and adds an activity indicator
|
|
||
| /** @fn addActivityIndicator: | ||
| @brief Creates and add activity indicator to the center of the specified view. | ||
| @param view The View where indicator is shown. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: View should be lowercase
|
Do you have any idea when this can be added to the latest release? |
|
I'll merge it after the comment changes are made, and it'll be out in the the next release (after Firebase's next major version). |
|
@morganchen12 sorry this is my first public PR – do I need to make the comment changes which you specified? Or do I need to approve them somehow? |
|
If you make the changes locally and push to the same branch, the PR will update automatically. |
|
Looks good, thanks! Expect this to be released in the next two weeks or so. |
|
@morganchen12 thank you! |
No description provided.