Implemented allowNewEmailAccounts #450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis CI fails also on master due to deprecation in FUIAccountSettingsOperation. I've mentioned issue here #125 |
morganchen12
requested changes
May 17, 2018
FirebaseAuthUI/FUIAuth.h
Outdated
| /** @property allowNewEmailAccounts | ||
| @brief Whether to allow new user sign, defaults to YES. | ||
| */ | ||
| @property(nonatomic, assign, getter=allowedNewEmailAccounts) BOOL allowNewEmailAccounts; |
There was a problem hiding this comment.
I don't think this needs a custom getter name (but if you'd like to keep it, consider renaming to allowsNewEmailAccounts)
FirebaseAuthUI/FUIAuth.m
Outdated
| controller = [[FUIEmailEntryViewController alloc] initWithAuthUI:self]; | ||
| } | ||
| } | ||
| else{ |
There was a problem hiding this comment.
nit: space after else
…nto allow_new_email_login
|
Fixed code nits and merged with master to pass TravisCI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented allow new email accounts, Reference #125