Skip to content

Fix bad loop behavior on invalidation in FUIArray, add tests #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2018
Merged

Fix bad loop behavior on invalidation in FUIArray, add tests #478

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions FirebaseDatabaseUI/FUIArray.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ - (void)invalidate {

// Remove all values on invalidation.
[self didUpdate];
for (NSInteger i = 0; i < self.snapshots.count; i++) {
for (NSInteger i = 0; i < self.snapshots.count; /* no i++ since we modify the array instead*/ ) {
FIRDataSnapshot *current = self.snapshots[i];

[self.snapshots removeObjectAtIndex:i];
Expand Down Expand Up @@ -269,7 +269,7 @@ - (id)objectAtIndexedSubscript:(NSUInteger)index {
return [self snapshotAtIndex:index];
}

- (void)setObject:(id)obj atIndexedSubscript:(NSUInteger)index{
- (void)setObject:(id)obj atIndexedSubscript:(NSUInteger)index {
@throw [NSException exceptionWithName:@"FUIArraySetIndexWithSubscript"
reason:@"Setting an object as FUIArray[i] is not supported."
userInfo:nil];
Expand Down
9 changes: 9 additions & 0 deletions FirebaseDatabaseUITests/FUIArrayTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,4 +476,13 @@ - (void)testArraySendsMessagesAfterReceivingValueEvent {
XCTAssert(ended == 1, @"expected array to end updates exactly once");
}

- (void)testRemovesAllElementsWhenInvalidated {
[self.observable populateWithCount:10];
[self.firebaseArray invalidate];

XCTAssert(self.firebaseArray.count == 0,
@"Expected array to be empty after invalidation, instead got %ld elements",
self.firebaseArray.count);
}

@end