Skip to content

Conversation

@renkelvin
Copy link
Contributor

Copy link
Contributor

@Yue-Wang-Google Yue-Wang-Google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably need to revert project.pbxproj but otherwise LGTM

Copy link
Contributor

@Yue-Wang-Google Yue-Wang-Google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert approval. The footer link should always right aligned. see https://docs.google.com/document/d/1IwCfD1kJudZLOoU-Efcv3nTkGCfiB3ojPerybExuFiU/edit and reference docs in the "References" section. We need to make it consistant across android web and ios.

Copy link
Contributor

@Yue-Wang-Google Yue-Wang-Google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@renkelvin renkelvin merged commit 7cef0f1 into master Mar 18, 2019
@renkelvin renkelvin deleted the tos branch March 18, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants