Make Sign in with Apple button white in dark mode #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
reviewed
Jun 9, 2020
Contributor
morganchen12
left a comment
morganchen12
left a comment
There was a problem hiding this comment.
Had one nit, otherwise LGTM.
Thanks!
OAuth/FirebaseOAuthUI/FUIOAuth.m
Outdated
| _signInLabel = buttonLabelText; | ||
| _shortName = shortName; | ||
| _buttonBackgroundColor = buttonColor; | ||
| _buttonTextColor = [UIColor colorWithRed:1.0 green:1.0 blue:1.0 alpha:1.0]; |
Contributor
There was a problem hiding this comment.
nit: Can this just be [UIColor whiteColor]?
Contributor
Author
There was a problem hiding this comment.
Sure! Just tried to follow the style of the current code. Will update.
Contributor
Author
|
@morganchen12 could you trigger a new build? Looks like it stalled on:
|
Contributor
|
I'll just merge and fix the build in master if it breaks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes 'Sign in with Apple'-button does not follow the Apple Human Interface Guidelines #871