Skip to content

Conversation

@ttermeer-reboundcg
Copy link
Contributor

Fix for #880 and possibly #830

My knowledge is limited for Objective-C so any feedback is welcomed. Solution taken from stackoverflow

Allows bytes to string conversion when not nul terminated
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@morganchen12
Copy link
Contributor

It seems you've signed the CLA with an email that's different than the one in your commit. Can you re-sign the CLA with the correct email?

@ttermeer-reboundcg
Copy link
Contributor Author

@morganchen12 I verified. Commit is under the right email address but the CLA just got approved 6 hours ago.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 7, 2020
@morganchen12
Copy link
Contributor

Thanks!

@morganchen12 morganchen12 merged commit 1980215 into firebase:master Jul 7, 2020
@ttermeer-reboundcg ttermeer-reboundcg deleted the fix_apple_identityToken branch July 7, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants