update FUIGoogleAuth for GoogleSignIn 6 #987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morganchen12
commented
Jul 21, 2021
| @brief Requests the scopes in the `scopes` array. | ||
| */ | ||
| - (void)requestScopesWithPresentingViewController:(UIViewController *)presentingViewController | ||
| completion:(FUIAuthProviderSignInCompletionBlock)completion; |
Contributor
Author
There was a problem hiding this comment.
@rosalyntan does this approach make sense?
Member
There was a problem hiding this comment.
I think so -- so will the developer flow for this be to call signInWithDefaultValue first to authenticate, and then requestScopesWithPresentingViewController to request the appropriate scopes?
rosalyntan
reviewed
Jul 21, 2021
FirebaseGoogleAuthUI/Sources/Public/FirebaseGoogleAuthUI/FUIGoogleAuth.h
Outdated
Show resolved
Hide resolved
| @brief Requests the scopes in the `scopes` array. | ||
| */ | ||
| - (void)requestScopesWithPresentingViewController:(UIViewController *)presentingViewController | ||
| completion:(FUIAuthProviderSignInCompletionBlock)completion; |
Member
There was a problem hiding this comment.
I think so -- so will the developer flow for this be to call signInWithDefaultValue first to authenticate, and then requestScopesWithPresentingViewController to request the appropriate scopes?
rosalyntan
approved these changes
Jul 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #951.