Skip to content

Incorporate features from firebase-functions#1820#32

Merged
inlined merged 2 commits intofunctions-migrationsfrom
inlined.cf3-params-refactor-pt2
Mar 18, 2026
Merged

Incorporate features from firebase-functions#1820#32
inlined merged 2 commits intofunctions-migrationsfrom
inlined.cf3-params-refactor-pt2

Conversation

@inlined
Copy link
Member

@inlined inlined commented Mar 11, 2026

Companion PR to firebase-functions#1820. Support more migrations!

@gemini-code-assist
Copy link
Contributor

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@inlined
Copy link
Member Author

inlined commented Mar 11, 2026

TODO: should probably mention to the agent that it may need to upgrade to the latest SDK and CLI versions

@inlined
Copy link
Member Author

inlined commented Mar 11, 2026

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the SKILL.md file to incorporate new features for Firebase Functions parameters, including usage in provider-specific configurations and string interpolation with expr. The changes primarily consist of adding new rules and examples. I found a minor syntax error in one of the new code examples and have provided a suggestion to correct it.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@inlined inlined requested review from jhuleatt and joehan March 11, 2026 23:11
@inlined inlined merged commit 06f109b into functions-migrations Mar 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants