Incorporate features from firebase-functions#1820#32
Merged
inlined merged 2 commits intofunctions-migrationsfrom Mar 18, 2026
Merged
Incorporate features from firebase-functions#1820#32inlined merged 2 commits intofunctions-migrationsfrom
inlined merged 2 commits intofunctions-migrationsfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Member
Author
|
TODO: should probably mention to the agent that it may need to upgrade to the latest SDK and CLI versions |
Member
Author
|
/gemini review |
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SKILL.md file to incorporate new features for Firebase Functions parameters, including usage in provider-specific configurations and string interpolation with expr. The changes primarily consist of adding new rules and examples. I found a minor syntax error in one of the new code examples and have provided a suggestion to correct it.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
jhuleatt
approved these changes
Mar 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Companion PR to firebase-functions#1820. Support more migrations!