chore: move dependencies about to fix vulnerabilities#2654
Merged
Conversation
6120fac to
93b6113
Compare
HassanBahati
approved these changes
Feb 24, 2026
cabljac
added a commit
that referenced
this pull request
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes all but one npm audit vulnerability with firestore-bigquery-changetracker.
It moves certain dependencies to dev deps. We have to be careful because in the past the build/deploy process of extensions doesn't like this - I think it omits dev dependencies at some point, and then at build time we get typescript errors in e.g test files.
The solution is a separate tsconfig for build, so the test files aren't seen at build time.
The Firebase Extensions deploy process likely does something like:
--omit=dev or NODE_ENV=production)
So on the remote server, only dependencies are installed. This is why jest in dependencies was working (but wasteful) - having a separate
tsconfig.build.jsonwith "types": ["node"] fixed it as the build no longer asks for types that aren't installed