Skip to content

chore(deps): batch apply 31 dependabot dependency bumps#2874

Open
CorieW wants to merge 2 commits into
nextfrom
chore/batch-dependabot-deps
Open

chore(deps): batch apply 31 dependabot dependency bumps#2874
CorieW wants to merge 2 commits into
nextfrom
chore/batch-dependabot-deps

Conversation

@CorieW
Copy link
Copy Markdown
Member

@CorieW CorieW commented Jun 1, 2026

Summary

Consolidates 31 Dependabot PRs into a single reviewable commit. All extension functions build cleanly (tsc passes with zero errors on all 8 affected extensions).

Note: One merge-conflict resolution was required — lerna was upgraded from ^3.4.3 to ^9.0.7 (PR #2870), which dropped qs as a transitive dependency. PR #2864 attempted to bump qs in the root package-lock.json; the lerna upgrade took precedence and qs was removed from the root lock file accordingly.

Dependabot PRs included

PR Package From To Location
#2872 group (8 updates) delete-user-data area
#2870 tmp, lerna 0.0.33, ^3.4.3 0.2.6, ^9.0.7 root
#2869 qs, express firestore-counter/functions
#2866 group (8 updates) firestore-bigquery-export area
#2865 qs, express firestore-bigquery-export/firestore-bigquery-change-tracker
#2864 qs 6.15.1 6.15.2 root (superseded by lerna upgrade — see note above)
#2863 qs, express firestore-send-email/functions
#2862 protobufjs 7.5.4 7.6.1 rtdb-limit-child-nodes/functions
#2861 ws 8.20.0 8.20.1 storage-resize-images/functions
#2860 protobufjs 7.5.4 7.6.1 firestore-shorten-urls-bitly/functions
#2859 @tootallnate/once 2.0.0 2.0.1 firestore-counter/functions
#2858 @tootallnate/once 2.0.0 2.0.1 firestore-bigquery-export/scripts/gen-schema-view
#2857 @tootallnate/once 2.0.0 2.0.1 firestore-bigquery-export/scripts/import
#2856 @tootallnate/once 2.0.0 2.0.1 rtdb-limit-child-nodes/functions
#2853 brace-expansion 5.0.5 5.0.6 firestore-bigquery-export/functions
#2848 @protobufjs/utf8 1.1.0 1.1.1 firestore-bigquery-export/scripts/gen-schema-view
#2847 @protobufjs/utf8 1.1.0 1.1.1 firestore-counter/stress_test/bin
#2846 @protobufjs/utf8 1.1.0 1.1.1 _emulator/functions
#2845 @protobufjs/utf8 1.1.0 1.1.1 delete-user-data/test-data
#2844 @protobufjs/utf8 1.1.0 1.1.1 firestore-counter/clients/web
#2843 @protobufjs/utf8 1.1.0 1.1.1 firestore-counter/functions
#2842 @protobufjs/utf8 1.1.0 1.1.1 firestore-bigquery-export/scripts/import
#2841 @protobufjs/utf8 1.1.0 1.1.1 delete-user-data/functions
#2840 protobufjs 7.5.5 7.5.8 samples/rtdb-uppercase-messages/functions
#2839 protobufjs 7.5.4 7.5.8 storage-resize-images/functions (resolved: kept newer 7.6.2 from earlier group PR)
#2838 @protobufjs/utf8 1.1.0 1.1.1 firestore-send-email/functions
#2837 @protobufjs/utf8 1.1.0 1.1.1 samples/rtdb-uppercase-messages/functions/integration-tests/functions
#2836 @protobufjs/utf8 1.1.0 1.1.1 firestore-bigquery-export/functions
#2835 @protobufjs/utf8 1.1.0 1.1.1 storage-resize-images/functions
#2834 @protobufjs/utf8 1.1.0 1.1.1 firestore-bigquery-export/firestore-bigquery-change-tracker
#2833 @protobufjs/utf8 1.1.0 1.1.1 firestore-counter/clients/node

Changes by package

Package From To Affected paths
lerna ^3.4.3 ^9.0.7 root
tmp 0.0.33 0.2.6 root
ts-jest 29.4.9 29.4.11 root, delete-user-data/functions
@types/node ^22.0.0 ^20.19.41 delete-user-data/functions
protobufjs 7.5.4 7.6.2 rtdb-limit-child-nodes/functions, firestore-shorten-urls-bitly/functions, storage-resize-images/functions, samples/rtdb-uppercase-messages/functions
@protobufjs/utf8 1.1.0 1.1.1 delete-user-data/functions, delete-user-data/test-data, firestore-bigquery-export/*, firestore-counter/*, firestore-send-email/functions, storage-resize-images/functions, _emulator/functions, samples/rtdb-uppercase-messages/*
@tootallnate/once 2.0.0 2.0.1 firestore-counter/functions, firestore-bigquery-export/scripts/gen-schema-view, firestore-bigquery-export/scripts/import, rtdb-limit-child-nodes/functions
ws 8.20.0 8.20.1 storage-resize-images/functions
brace-expansion 5.0.5 5.0.6 firestore-bigquery-export/functions
qs 6.15.1 6.15.2 firestore-counter/functions, firestore-bigquery-export/firestore-bigquery-change-tracker, firestore-send-email/functions
express (various) (various) firestore-counter/functions, firestore-bigquery-export/firestore-bigquery-change-tracker, firestore-send-email/functions

Test plan

  • All 8 extension functions build cleanly (tsc with zero errors) after npm install
  • Deploy to dev-extensions-testing once Firebase Extensions service recovers from current backend incident affecting createSource LRO

Consolidates dependency updates from PRs #2833-#2872 into a single
commit to reduce noise and simplify review.

Co-authored-by: Cursor <cursoragent@cursor.com>
@CorieW CorieW requested a review from a team as a code owner June 1, 2026 15:51
@google-cla
Copy link
Copy Markdown

google-cla Bot commented Jun 1, 2026

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request performs extensive dependency updates across multiple packages in the repository, including upgrading lerna and ts-jest, alongside various sub-dependency adjustments. The review feedback highlights a consistent issue where @types/node is downgraded to ^20.19.41 in several packages despite their engines being configured for Node 22, which could lead to type-checking issues and a lack of type safety for newer Node features.

"@google-cloud/pubsub": "^4.3.3",
"@types/express-serve-static-core": "4.19.8",
"@types/node": "^22.0.0",
"@types/node": "^20.19.41",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The engine is configured to Node 22 ("node": "22"). Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.

Suggested change
"@types/node": "^20.19.41",
"@types/node": "^22.0.0",

"@types/chai": "^4.1.6",
"@types/jest": "^29.5.14",
"@types/node": "^22.0.0",
"@types/node": "^20.19.41",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.

Suggested change
"@types/node": "^20.19.41",
"@types/node": "^22.0.0",

"@types/chai": "^4.1.6",
"@types/jest": "29.5.0",
"@types/node": "^22.0.0",
"@types/node": "^20.19.41",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.

Suggested change
"@types/node": "^20.19.41",
"@types/node": "^22.0.0",

"dependencies": {
"@types/express-serve-static-core": "4.19.8",
"@types/node": "^22.0.0",
"@types/node": "^20.19.41",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.

Suggested change
"@types/node": "^20.19.41",
"@types/node": "^22.0.0",

Increments patch version and adds changelog entry for all 8 extensions
whose dependencies were updated in the previous commit.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants