chore(deps): batch apply 31 dependabot dependency bumps#2874
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Code Review
This pull request performs extensive dependency updates across multiple packages in the repository, including upgrading lerna and ts-jest, alongside various sub-dependency adjustments. The review feedback highlights a consistent issue where @types/node is downgraded to ^20.19.41 in several packages despite their engines being configured for Node 22, which could lead to type-checking issues and a lack of type safety for newer Node features.
| "@google-cloud/pubsub": "^4.3.3", | ||
| "@types/express-serve-static-core": "4.19.8", | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^20.19.41", |
There was a problem hiding this comment.
The engine is configured to Node 22 ("node": "22"). Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.
| "@types/node": "^20.19.41", | |
| "@types/node": "^22.0.0", |
| "@types/chai": "^4.1.6", | ||
| "@types/jest": "^29.5.14", | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^20.19.41", |
There was a problem hiding this comment.
Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.
| "@types/node": "^20.19.41", | |
| "@types/node": "^22.0.0", |
| "@types/chai": "^4.1.6", | ||
| "@types/jest": "29.5.0", | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^20.19.41", |
There was a problem hiding this comment.
Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.
| "@types/node": "^20.19.41", | |
| "@types/node": "^22.0.0", |
| "dependencies": { | ||
| "@types/express-serve-static-core": "4.19.8", | ||
| "@types/node": "^22.0.0", | ||
| "@types/node": "^20.19.41", |
There was a problem hiding this comment.
Downgrading @types/node to ^20.19.41 removes type definitions for Node 22 specific APIs, which can lead to type-checking issues or lack of type safety for newer Node features. It is recommended to keep @types/node at ^22.0.0 to match the target runtime environment.
| "@types/node": "^20.19.41", | |
| "@types/node": "^22.0.0", |
Increments patch version and adds changelog entry for all 8 extensions whose dependencies were updated in the previous commit. Co-authored-by: Cursor <cursoragent@cursor.com>
Summary
Consolidates 31 Dependabot PRs into a single reviewable commit. All extension functions build cleanly (
tscpasses with zero errors on all 8 affected extensions).Dependabot PRs included
delete-user-dataareatmp,lerna0.0.33,^3.4.30.2.6,^9.0.7qs,expressfirestore-counter/functionsfirestore-bigquery-exportareaqs,expressfirestore-bigquery-export/firestore-bigquery-change-trackerqs6.15.16.15.2qs,expressfirestore-send-email/functionsprotobufjs7.5.47.6.1rtdb-limit-child-nodes/functionsws8.20.08.20.1storage-resize-images/functionsprotobufjs7.5.47.6.1firestore-shorten-urls-bitly/functions@tootallnate/once2.0.02.0.1firestore-counter/functions@tootallnate/once2.0.02.0.1firestore-bigquery-export/scripts/gen-schema-view@tootallnate/once2.0.02.0.1firestore-bigquery-export/scripts/import@tootallnate/once2.0.02.0.1rtdb-limit-child-nodes/functionsbrace-expansion5.0.55.0.6firestore-bigquery-export/functions@protobufjs/utf81.1.01.1.1firestore-bigquery-export/scripts/gen-schema-view@protobufjs/utf81.1.01.1.1firestore-counter/stress_test/bin@protobufjs/utf81.1.01.1.1_emulator/functions@protobufjs/utf81.1.01.1.1delete-user-data/test-data@protobufjs/utf81.1.01.1.1firestore-counter/clients/web@protobufjs/utf81.1.01.1.1firestore-counter/functions@protobufjs/utf81.1.01.1.1firestore-bigquery-export/scripts/import@protobufjs/utf81.1.01.1.1delete-user-data/functionsprotobufjs7.5.57.5.8samples/rtdb-uppercase-messages/functionsprotobufjs7.5.47.5.8storage-resize-images/functions(resolved: kept newer 7.6.2 from earlier group PR)@protobufjs/utf81.1.01.1.1firestore-send-email/functions@protobufjs/utf81.1.01.1.1samples/rtdb-uppercase-messages/functions/integration-tests/functions@protobufjs/utf81.1.01.1.1firestore-bigquery-export/functions@protobufjs/utf81.1.01.1.1storage-resize-images/functions@protobufjs/utf81.1.01.1.1firestore-bigquery-export/firestore-bigquery-change-tracker@protobufjs/utf81.1.01.1.1firestore-counter/clients/nodeChanges by package
lerna^3.4.3^9.0.7tmp0.0.330.2.6ts-jest29.4.929.4.11delete-user-data/functions@types/node^22.0.0^20.19.41delete-user-data/functionsprotobufjs7.5.47.6.2rtdb-limit-child-nodes/functions,firestore-shorten-urls-bitly/functions,storage-resize-images/functions,samples/rtdb-uppercase-messages/functions@protobufjs/utf81.1.01.1.1delete-user-data/functions,delete-user-data/test-data,firestore-bigquery-export/*,firestore-counter/*,firestore-send-email/functions,storage-resize-images/functions,_emulator/functions,samples/rtdb-uppercase-messages/*@tootallnate/once2.0.02.0.1firestore-counter/functions,firestore-bigquery-export/scripts/gen-schema-view,firestore-bigquery-export/scripts/import,rtdb-limit-child-nodes/functionsws8.20.08.20.1storage-resize-images/functionsbrace-expansion5.0.55.0.6firestore-bigquery-export/functionsqs6.15.16.15.2firestore-counter/functions,firestore-bigquery-export/firestore-bigquery-change-tracker,firestore-send-email/functionsexpressfirestore-counter/functions,firestore-bigquery-export/firestore-bigquery-change-tracker,firestore-send-email/functionsTest plan
tscwith zero errors) afternpm installdev-extensions-testingonce Firebase Extensions service recovers from current backend incident affectingcreateSourceLRO