Skip to content

Conversation

@joehan
Copy link
Collaborator

@joehan joehan commented Jun 1, 2022

No description provided.

@joehan joehan requested a review from a team as a code owner June 1, 2022 19:36
@@ -0,0 +1,198 @@
rules_version = '2';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these were exported from the extensions-testing project by firebase init. They can probably be replaced with default rules files for the purposes of this test.

Copy link
Collaborator Author

@joehan joehan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I also changed functions.yaml back to extension.yaml - not sure why this was switched over in the first place. Functions.yaml is an internal implementation detail for CF3 functions.

@dackers86
Copy link
Member

Note that I also changed functions.yaml back to extension.yaml - not sure why this was switched over in the first place. Functions.yaml is an internal implementation detail for CF3 functions.

Thanks! This was for debugging purposes and needed to be changed back.

- name: Run tests with coverage
run: npm run test-coverage
cd ./firestore-send-email/integration-test/ && firebase emulators:exec
"cd ../../ && npm run test-coverage" -P demo-test
Copy link
Member

@dackers86 dackers86 Jun 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially remove this from the CI config and keep it local to the extension. If the tests are ran locally, currently there is no emulator and the tests will fail.

As discussed I wonder if there is a way for this to run globally, as opposed running individually for each individual extension - but so that it will also be available for local development

@dackers86 dackers86 merged commit 8930d8e into @invertase/new-ext-emulator-investigation Jun 9, 2022
@dackers86 dackers86 deleted the jh-send-email-integration-test branch June 9, 2022 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants