-
Notifications
You must be signed in to change notification settings - Fork 424
Refactored tests to work with emulator suite #986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored tests to work with emulator suite #986
Conversation
| @@ -0,0 +1,198 @@ | |||
| rules_version = '2'; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like these were exported from the extensions-testing project by firebase init. They can probably be replaced with default rules files for the purposes of this test.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that I also changed functions.yaml back to extension.yaml - not sure why this was switched over in the first place. Functions.yaml is an internal implementation detail for CF3 functions.
Thanks! This was for debugging purposes and needed to be changed back. |
| - name: Run tests with coverage | ||
| run: npm run test-coverage | ||
| cd ./firestore-send-email/integration-test/ && firebase emulators:exec | ||
| "cd ../../ && npm run test-coverage" -P demo-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially remove this from the CI config and keep it local to the extension. If the tests are ran locally, currently there is no emulator and the tests will fail.
As discussed I wonder if there is a way for this to run globally, as opposed running individually for each individual extension - but so that it will also be available for local development
No description provided.