Skip to content

Refactored tests to work with emulator suite #986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Parent: @invertase/new ext emulator investigation
merged 9 commits into from
Jun 9, 2022
Merged

Refactored tests to work with emulator suite #986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7faba08
Refactored tests to work with emulator suite
joehan Jun 1, 2022
6883e01
change workflow to new command
joehan Jun 1, 2022
c748a49
use demo-test
joehan Jun 1, 2022
9714b88
formats
joehan Jun 1, 2022
b28b0cb
move --open-sesame
joehan Jun 1, 2022
cfc4e02
Changing test to use demo-test
joehan Jun 2, 2022
52ecd19
formats
joehan Jun 2, 2022
7da1667
remove --open-sesame
joehan Jun 2, 2022
97b5a5f
Run test-coverage against emulator
joehan Jun 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 3 additions & 7 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,14 +30,10 @@ jobs:
retry_wait_seconds: 60
max_attempts: 3
command: npm i -g firebase-tools
- name: Use extension commands
run: firebase --open-sesame extdev
- name: Run 'firestore-send-email' extension emulator
- name: Run 'firestore-send-email' tests on the Extension emulator
run:
cd ./firestore-send-email/functions/__tests__/emulator && sh
./start.sh
- name: Run tests with coverage
run: npm run test-coverage
cd ./firestore-send-email/integration-test/ && firebase emulators:exec
"cd ../../ && npm run test-coverage" -P demo-test
Copy link
Member

@dackers86 dackers86 Jun 8, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially remove this from the CI config and keep it local to the extension. If the tests are ran locally, currently there is no emulator and the tests will fail.

As discussed I wonder if there is a way for this to run globally, as opposed running individually for each individual extension - but so that it will also be available for local development

- name: Submit coverage
run: ./node_modules/.bin/codecov
env:
Expand Down
5 changes: 0 additions & 5 deletions firestore-send-email/.firebaserc
View file
Open in desktop

This file was deleted.

0 firestore-send-email/functions.yaml → firestore-send-email/extension.yaml
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion firestore-send-email/functions/__tests__/e2e.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import { smtpServer } from "./createSMTPServer";
process.env.FIRESTORE_EMULATOR_HOST = "localhost:8080";

admin.initializeApp({
projectId: "extensions-testing",
projectId: "demo-test",
});

const mail = "mail";
Expand Down
Loading