Skip to content

Conversation

@palsivertsen
Copy link
Contributor

Fixes #174

Token signature validation can be an expensive operation.
For tokens with invalid fields it is not necessary to check the
signature and it is therfore moved to the bottom.

Token signature validation can be an expensive operation.
For tokens with invalid fields it is not necessary to check the
signature and it is therfore moved to the bottom.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@palsivertsen
Copy link
Contributor Author

I signed it!

@hiranya911 hiranya911 self-assigned this Sep 13, 2018
@hiranya911
Copy link
Contributor

Code changes LGTM. Thanks @palsivertsen for putting this together. I'm wondering why the CLA check hasn't passed yet. Can you review the following instructions, and see everything is in order:

It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

@palsivertsen
Copy link
Contributor Author

There where some issues with the CLA. I updated the document and CLA is pending. Hopefully processed today.

@palsivertsen
Copy link
Contributor Author

@hiranya911 can you recheck the CLA?

@googlebot
Copy link

CLAs look good, thanks!

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hiranya911 hiranya911 merged commit d12567f into firebase:dev Oct 7, 2018
@palsivertsen palsivertsen deleted the token-validate-fail-fast branch October 10, 2018 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants