-
Notifications
You must be signed in to change notification settings - Fork 269
Move token signature verification after fields #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move token signature verification after fields #175
Conversation
Token signature validation can be an expensive operation. For tokens with invalid fields it is not necessary to check the signature and it is therfore moved to the bottom.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
|
I signed it! |
|
Code changes LGTM. Thanks @palsivertsen for putting this together. I'm wondering why the CLA check hasn't passed yet. Can you review the following instructions, and see everything is in order:
|
|
There where some issues with the CLA. I updated the document and CLA is pending. Hopefully processed today. |
|
@hiranya911 can you recheck the CLA? |
|
CLAs look good, thanks! |
hiranya911
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fixes #174
Token signature validation can be an expensive operation.
For tokens with invalid fields it is not necessary to check the
signature and it is therfore moved to the bottom.