Skip to content

Move token signature verification after fields #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 7, 2018
Merged

Move token signature verification after fields #175

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ebac732
Move token signature verification after fields
palsivertsen Sep 13, 2018
171fc85
Merge branch 'dev' into token-validate-fail-fast
palsivertsen Sep 17, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions auth/auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,9 +220,6 @@ func (c *Client) VerifyIDToken(ctx context.Context, idToken string) (*Token, err
return nil, fmt.Errorf("id token must be a non-empty string")
}

if err := verifyToken(ctx, idToken, c.keySource); err != nil {
return nil, err
}
segments := strings.Split(idToken, ".")

var (
Expand Down Expand Up @@ -281,6 +278,13 @@ func (c *Client) VerifyIDToken(ctx context.Context, idToken string) (*Token, err
return nil, err
}
payload.UID = payload.Subject

// Verifying the signature requires syncronized access to a key store and
// potentially issues a http request. Validating the fields of the token is
// cheaper and invalid tokens will fail faster.
if err := verifyToken(ctx, idToken, c.keySource); err != nil {
return nil, err
}
return &payload, nil
}

Expand Down