Add class for SAML provider config.#419
Merged
micahstairs merged 5 commits intoidp-configfrom May 18, 2020
Merged
Conversation
hiranya911
suggested changes
May 18, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks pretty good. Just need to remove some of the nested types from the public API surface.
src/test/java/com/google/firebase/auth/SamlProviderConfigTest.java
Outdated
Show resolved
Hide resolved
micahstairs
assigned
hiranya911 and
micahstairs and unassigned
micahstairs and
hiranya911
hiranya911
suggested changes
May 18, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks good. Please fix the compilation failure.
micahstairs
changed the base branch from
micahstairs-provider-cleanup
to
idp-config
micahstairs
force-pushed
the
micahstairs-saml
branch
from
4546b27 to
515463c
Compare
hiranya911
suggested changes
May 18, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
I was under the impression that we can deserialize the response into an instance of SamlProviderConfigResponse, and then realized we can't really do that. I've proposed a couple of options to clean things up a bit. Let me know how you feel about them.
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
Adds a class for the SAML provider config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a class for the SAML provider config.