Add operations to create and delete SAML provider configs.#420
Merged
micahstairs merged 6 commits intoidp-configfrom May 21, 2020
Merged
Add operations to create and delete SAML provider configs.#420micahstairs merged 6 commits intoidp-configfrom
micahstairs merged 6 commits intoidp-configfrom
Conversation
micahstairs
force-pushed
the
micahstairs-saml
branch
from
4546b27 to
515463c
Compare
micahstairs
force-pushed
the
micahstairs-saml-create-delete
branch
from
89202d9 to
72170c4
Compare
micahstairs
force-pushed
the
micahstairs-saml-create-delete
branch
from
72170c4 to
28db833
Compare
hiranya911
suggested changes
May 21, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Looks pretty good. Just a few nits to clean up.
src/main/java/com/google/firebase/auth/AbstractFirebaseAuth.java
Outdated
Show resolved
Hide resolved
src/main/java/com/google/firebase/auth/AbstractFirebaseAuth.java
Outdated
Show resolved
Hide resolved
micahstairs
assigned
lahirumaramba and
hiranya911 and unassigned
lahirumaramba and
micahstairs
hiranya911
suggested changes
May 21, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
Overall looks good. Found a few oversights here and there.
src/main/java/com/google/firebase/auth/AbstractFirebaseAuth.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/auth/OidcProviderConfigTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/google/firebase/auth/OidcProviderConfigTest.java
Outdated
Show resolved
Hide resolved
hiranya911
approved these changes
May 21, 2020
Contributor
hiranya911
left a comment
hiranya911
left a comment
There was a problem hiding this comment.
LGTM with a suggestion. Feel free to ignore it.
src/test/java/com/google/firebase/auth/FirebaseUserManagerTest.java
Outdated
Show resolved
Hide resolved
micahstairs
added a commit
that referenced
this pull request
Jun 12, 2020
This adds operations to create and delete SAML provider configs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds operations to create and delete SAML provider configs. I've included both unit tests and integration tests.
I'm a little concerned about the number of assertions I have in a few of the tests. I'm open to any suggestions you may have!