Skip to content

Move check outside CallableOperation.#431

Merged
micahstairs merged 1 commit intoidp-configfrom
micahstairs-update-tenant-check
Jun 4, 2020
Merged

Move check outside CallableOperation.#431
micahstairs merged 1 commit intoidp-configfrom
micahstairs-update-tenant-check

Conversation

@micahstairs
Copy link
Contributor

Moves the check in FirebaseUserManager.updateTenant outside CallableOperation in TenantManager.updateTenantOp, addressing an existing TODO.

Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hiranya911 hiranya911 assigned micahstairs and unassigned hiranya911 Jun 3, 2020
@micahstairs micahstairs merged commit de6b982 into idp-config Jun 4, 2020
@micahstairs micahstairs deleted the micahstairs-update-tenant-check branch June 4, 2020 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants