ESBuild failures related to farmhash on firebase-admin v12.1.0

[infovore]

Environment

• Operating System version: Mac OS Ventura (13.x) on Intel
• Firebase SDK version: firebase-admin v12.1.0)
• Firebase Product: firebase-admin for node
• Node.js version: 20.5.1
• NPM version: 9.8.0

Problem

Steps to reproduce:

Starting work on a colleague's project, I run npm install. We've pinned firebase-admin to ^12.0.0; this installs 12.1.0. This works correctly.

When I build my SvelteKit project - which will eventually use ESBuild - I get the same errors as reported in this StackOverflow post - "can't resolve build/Debug/farmhash.node".

When I pin firebase-admin to 12.0.0 (specific version): no such error. So the StackOverflow post, filed a day or two ago, seems to be related to something in the 12.1.0 changes.

Beyond this, I'm a bit lost, but managed to find evidence of someone else with the same issue, and now have a workaround - pinning to an old verison. There seem to have been other farmhash issues that Doug Stevneson has mentioned.

[google-oss-bot]

I found a few problems with this issue:

• I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.
• This issue does not seem to follow the issue template. Make sure you provide all the required information.

[wodCZ]

Could be related to this: lovell/farmhash#48

Edit, sorry, probably not, since you're on Intel.

[infovore]

Update: farmhash needs to be specified as an ESBuild external. In the case of svelte-adapter-appengine, that was an extra configuration step I hadn't configured, is all.

[balloman]

@infovore can you talk a little bit more about what you did? I reverted to 12.0.0, but I'm hoping this doesn't prevent me from upgrading indefinitely

[infovore]

@balloman of course - I added farmhash to the externals section of my esbuild configuration.

Vite - in optimizeDeps.externals - and other build tools should have similar configuration options.

[ramigabai]

Did anyone made it work with @nx/esbuild ? Adding "external": [ "farmhash" ] doesn't work..

[dantheli]

I'm also facing this with Next.js and had to downgrade to 12.0.0 in order to build as well.