Skip to content

chore: Deprecate support for Node.js 20#3128

Merged
lahirumaramba merged 2 commits intomainfrom
lm-deprecate-node20
May 6, 2026
Merged

chore: Deprecate support for Node.js 20#3128
lahirumaramba merged 2 commits intomainfrom
lm-deprecate-node20

Conversation

@lahirumaramba
Copy link
Copy Markdown
Member

Node.js 20 has reached EOL. Deprecate support for Node.js 20

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Node.js version requirements in the documentation, deprecating support for Node.js 18 and 20 while encouraging the use of Node.js 22. A review comment pointed out an inconsistency in the contributor prerequisites, suggesting that Node.js 22 should be required instead of Node.js 18 to align with the project's updated environment support.

I am having trouble creating individual review comments. Click here to see my feedback.

CONTRIBUTING.md (90)

medium

There is an inconsistency between this change and the PR's objective. The PR aims to deprecate Node.js 20, yet this line sets the minimum prerequisite for contributors to Node.js 18. If Node.js 20 is indeed being deprecated in favor of Node.js 22 (as stated in the README), the contributor prerequisites should be updated to Node.js 22 to ensure a modern development environment and consistency with the project's direction.

1. Node.js 22 or higher.

Copy link
Copy Markdown
Collaborator

@jonathanedey jonathanedey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@lahirumaramba lahirumaramba merged commit 363a302 into main May 6, 2026
11 checks passed
@lahirumaramba lahirumaramba deleted the lm-deprecate-node20 branch May 6, 2026 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants