fix(fcm): Map topic subscription RESOURCE_EXHAUSTED server code to new TOPICS_SUBSCRIPTION_RATE_EXCEEDED SDK error code#3148
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new error code, TOPICS_SUBSCRIPTION_RATE_EXCEEDED, to handle rate-limiting scenarios in topic management. It updates the server-to-client error mapping so that RESOURCE_EXHAUSTED now correctly maps to this new code instead of TOO_MANY_TOPICS. Feedback was provided to generalize the error message to cover both subscription and unsubscription operations, as the current wording is specific to subscribing.
OrlandriaH-G
approved these changes
May 15, 2026
lahirumaramba
approved these changes
May 15, 2026
…PTION_RATE_EXCEEDED` SDK error code
lahirumaramba
pushed a commit
that referenced
this pull request
May 26, 2026
…new `TOPICS_SUBSCRIPTION_RATE_EXCEEDED` SDK error code (#3148) * fix(fcm): Map `RESOURCE_EXHAUSTED` server code to new `TOPICS_SUBSCRIPTION_RATE_EXCEEDED` SDK error code * fix: Update apidocs * fix: Address gemini review * fix: Apply TW review changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we incorrectly mapped the topic subscription
RESOURCE_EXHAUSTEDFCM server code toTOO_MANY_TOPICSSDK error code leading to misleading error messaging for the cause of the error. This PR introduces a newTOPICS_SUBSCRIPTION_RATE_EXCEEDEDto correctly attribute the error.RELEASE_NOTE: Mapped the topic management
RESOURCE_EXHAUSTEDserver error to a newTOPICS_SUBSCRIPTION_RATE_EXCEEDEDcode instead ofTOO_MANY_TOPICSto improve subscription rate limits error messaging.