Skip to content

chore: Drop send-tweet and upgrade GitHub Actions#3158

Merged
jonathanedey merged 4 commits into
v14from
je-update-actions
May 25, 2026
Merged

chore: Drop send-tweet and upgrade GitHub Actions#3158
jonathanedey merged 4 commits into
v14from
je-update-actions

Conversation

@jonathanedey
Copy link
Copy Markdown
Collaborator

Updates workflows and custom actions to resolve GitHub's runner deprecation warnings.

  • Updates actions/checkout, actions/setup-node, actions/setup-java, actions/upload-artifact, and actions/download-artifact actions across all workflows. This resolves Node.js 20 deprecation warnings and ensures compatibility with Node.js 24+ runners.
  • Upgraded send-email action to use node24 runtime and updated dependencies.
  • Removed unused send-tweet custom action.

@jonathanedey jonathanedey added the release:stage Stage a release candidate label May 21, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the send-tweet action and updates the send-email action by adopting ESM imports and bumping dependency versions. Critical feedback was provided regarding the use of an unsupported node24 runtime and non-existent dependency versions for @actions/core and axios. Additionally, a more idiomatic approach for object iteration was suggested to replace the for...in loop.

Comment thread .github/actions/send-email/action.yml
Comment thread .github/actions/send-email/package.json
Comment thread .github/actions/send-email/index.js Outdated
Copy link
Copy Markdown
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jonathanedey jonathanedey merged commit eae22a9 into v14 May 25, 2026
14 checks passed
@jonathanedey jonathanedey deleted the je-update-actions branch May 25, 2026 16:36
lahirumaramba pushed a commit that referenced this pull request May 26, 2026
* chore: Update send-email GHA and remove send-tweet GHA

* chore: Update `checkout` and `setup-node` GHAs

* chore: Update `setup-java`, `upload-artifact`, and `download-artifact` GHAs

* fix: address gemini review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:stage Stage a release candidate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants