Add integration tests for Remote Config #826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hiranya911
suggested changes
Mar 30, 2020
hiranya911
suggested changes
Mar 31, 2020
hiranya911
suggested changes
Apr 1, 2020
| }); | ||
|
|
||
| INVALID_CONDITIONS.forEach((invalidConditions) => { | ||
| console.log(inputTemplate); |
| }); | ||
|
|
||
| // validate input template | ||
| testInputTemplate((t: RemoteConfigTemplate) => { remoteConfig.validateTemplate(t); }); |
There was a problem hiding this comment.
Can't you just do testInputTemplate(remoteConfig.validateTemplate);
There was a problem hiding this comment.
I tried that but it gives me the following type error. Not quite sure why.
testInvalidInputTemplates(remoteConfig.validateTemplate);
^
TypeError: Cannot read property 'validateTemplate' of undefined
| }); | ||
| }); | ||
|
|
||
| function testInputTemplate(rcOperation: Function): void { |
There was a problem hiding this comment.
Use a more descriptive name. Perhaps testInvalidInputTemplates()?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
validateTemplate()andpublishTemplate()functions