Skip to content

Add condition tag colors list #832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2020
Merged

Add condition tag colors list #832

merged 1 commit into from
Apr 2, 2020

Conversation

lahirumaramba
Copy link
Member

  • Add an enum to list all the valid tag colors for conditions

Note: API is still under review. Getting a head start here. Should merge after #826

@lahirumaramba lahirumaramba force-pushed the lm-remoteconfig-tagcolor branch from 16be445 to dcb1dd7 Compare March 31, 2020 19:44
hiranya911
hiranya911 approved these changes Mar 31, 2020
View reviewed changes
Copy link
Contributor

@hiranya911 hiranya911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@lahirumaramba lahirumaramba merged commit b6a87ac into remote-config Apr 2, 2020
@lahirumaramba lahirumaramba deleted the lm-remoteconfig-tagcolor branch April 2, 2020 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@hiranya911 hiranya911 hiranya911 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@lahirumaramba lahirumaramba

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@lahirumaramba @hiranya911