Skip to content

Conversation

@James201311
Copy link
Member

@James201311 James201311 commented Jul 5, 2021

This is a check that before the last IO release
It's safe to delete this check, after we released java8 bytecode

@googlebot googlebot added the cla: yes Override cla label Jul 5, 2021
@James201311 James201311 requested a review from vkryachko July 5, 2021 14:44
Copy link
Member

@vkryachko vkryachko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pls also remove test resources:

NoStaticOrDefaultMethodsInInterfacesNegativeCases.java
NoStaticOrDefaultMethodsInInterfacesPositiveCases.java

@James201311 James201311 requested a review from vkryachko July 5, 2021 14:48
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2021

Binary Size Report

Affected SDKs

No changes between base commit (2bb3364) and head commit (8be790bc).

Test Logs

Notes

Head commit (8be790bc) is created by Prow via merging commits: 2bb3364 4ff7690.

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Jul 5, 2021

Coverage Report

Affected SDKs

  • firebase-database

    SDK overall coverage changed from 50.02% (2bb3364) to 50.04% (8be790bc) by +0.02%.

    Filename Base (2bb3364) Head (8be790bc) Diff
    RetryHelper.java 70.97% 74.19% +3.23%
  • firebase-firestore

    SDK overall coverage changed from 47.10% (2bb3364) to 47.18% (8be790bc) by +0.09%.

    Filename Base (2bb3364) Head (8be790bc) Diff
    AsyncQueue.java 77.89% 78.39% +0.50%
    FirestoreClient.java 30.08% 34.96% +4.88%
    LruGarbageCollector.java 84.11% 93.46% +9.35%
  • firebase-messaging

    SDK overall coverage changed from 83.43% (2bb3364) to 83.56% (8be790bc) by +0.14%.

    Filename Base (2bb3364) Head (8be790bc) Diff
    TopicsSubscriber.java 89.66% 91.38% +1.72%
  • firebase-storage

    SDK overall coverage did not change between base commit (2bb3364) and head commit (8be790bc). However there are changes in individual files.

    Filename Base (2bb3364) Head (8be790bc) Diff
    StreamDownloadTask.java 88.89% 88.41% -0.48%
    UploadTask.java 80.58% 80.94% +0.36%

Test Logs

Notes

HTML coverage reports can be produced locally with ./gradlew <product>:checkCoverage.
Report files are located at <product-build-dir>/reports/jacoco/.

Head commit (8be790bc) is created by Prow via merging commits: 2bb3364 4ff7690.

@James201311
Copy link
Member Author

/test check-changed

@James201311
Copy link
Member Author

/retest

@google-oss-bot
Copy link
Contributor

@James201311: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
device-check-changed 4ff7690 link /test device-check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vkryachko vkryachko merged commit 4ec2725 into master Jul 5, 2021
@vkryachko vkryachko deleted the yizhaoh.delete-check branch July 5, 2021 16:32
@firebase firebase locked and limited conversation to collaborators Aug 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants