Skip to content

Conversation

@rsgowman
Copy link
Member

As suggested by Rachel.

Copy link

@earnestsaunders earnestsaunders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

@rsgowman: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
check-changed 55ecf8c link /test check-changed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rsgowman rsgowman merged commit 33706a9 into master Jun 21, 2019
@rsgowman rsgowman deleted the rsgowman/doc_backport branch June 21, 2019 16:23
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes Override cla size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants