Skip to content

Fix FirebaseFirestore formatting. #556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Create google.yml
merged 1 commit into from
Jun 21, 2019
Merged

Fix FirebaseFirestore formatting. #556

merged 1 commit into from
Jun 21, 2019

Conversation

@allisonbm92
Copy link
Contributor

FirebaseFirestore.java is causing check to fail due to formatting errors.

@allisonbm92 allisonbm92 requested a review from rsgowman June 21, 2019 20:24
@googlebot googlebot added the cla: yes Override cla label Jun 21, 2019
@allisonbm92
Copy link
Contributor Author

/test device-check-changed

@allisonbm92 allisonbm92 requested a review from thebrianchen June 21, 2019 20:49
thebrianchen
thebrianchen approved these changes Jun 21, 2019
View reviewed changes
Copy link

@thebrianchen thebrianchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@allisonbm92 allisonbm92 merged commit 832f4de into master Jun 21, 2019
@allisonbm92 allisonbm92 deleted the allison-fs-format branch June 21, 2019 21:12
schmidt-sebastian pushed a commit that referenced this pull request Jun 25, 2019
@allisonbm92 @schmidt-sebastian
Fix FirebaseFirestore formatting. (#556)
383cbce
schmidt-sebastian pushed a commit that referenced this pull request Jun 27, 2019
@allisonbm92 @schmidt-sebastian
Fix FirebaseFirestore formatting. (#556)
1e99b39
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@rsgowman rsgowman Awaiting requested review from rsgowman

1 more reviewer

@thebrianchen thebrianchen thebrianchen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes Override cla size/XS

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@allisonbm92 @thebrianchen @googlebot @google-oss-bot