Skip to content

Refactor Filters #570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Create google.yml
merged 12 commits into from
Jun 27, 2019
Merged

Refactor Filters #570

merged 12 commits into from
Jun 27, 2019

Conversation

@thebrianchen
Copy link

@thebrianchen thebrianchen commented Jun 25, 2019 •
edited
Loading

Based off JS refactor filter with some additions:

  • @var-const's fix for array-contains
  • backporting test for IN queries with docIds from web

@googlebot googlebot added the cla: yes Override cla label Jun 25, 2019
@thebrianchen thebrianchen requested a review from wilhuff June 26, 2019 20:16
wilhuff
wilhuff reviewed Jun 27, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits.

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jun 27, 2019
@thebrianchen thebrianchen requested a review from wilhuff June 27, 2019 17:07
@thebrianchen thebrianchen assigned wilhuff and unassigned thebrianchen Jun 27, 2019
wilhuff
wilhuff approved these changes Jun 27, 2019
View reviewed changes
Copy link
Contributor

@wilhuff wilhuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wilhuff wilhuff assigned thebrianchen and unassigned wilhuff Jun 27, 2019
@thebrianchen thebrianchen merged commit 9ac7870 into master Jun 27, 2019
@thebrianchen thebrianchen deleted the bc/refactor-filter branch June 27, 2019 17:37
@wilhuff wilhuff mentioned this pull request Jul 15, 2019
Merged
@thebrianchen thebrianchen mentioned this pull request Aug 2, 2019
Merged
@firebase firebase locked and limited conversation to collaborators Oct 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@wilhuff wilhuff wilhuff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@thebrianchen thebrianchen

Labels

api: firestore cla: yes Override cla size/XL

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thebrianchen @wilhuff @googlebot @google-oss-bot